[bugfix] Fix the issue of incorrect mac address - #68
Open
cyclamenkde wants to merge 1 commit into
Open
cyclamenkde wants to merge 1 commit into
cyclamenkde wants to merge 1 commit into
Conversation
mondul
added a commit
to mondul/simpleDLNA
that referenced
this pull request
Sep 14, 2026
AddressToMacResolver formatted each octet with {:X}, which drops the
leading zero: a client at 01:AF:BC:00:0A:FF was reported as 1:AF:BC:0:A:FF.
MacAuthorizer does an exact lookup against the configured entries, which
IP.IsAcceptedMAC requires to be six two-digit groups, so any client whose
MAC contains an octet below 0x10 could never be admitted -- roughly a third
of all addresses.
This is the same one-character fix proposed upstream in nmaier#68
by @cyclamenkde; credit for spotting it is theirs. It is included here
because the configuration file added in the following commits makes MAC
restrictions a first-class, per-server setting, and shipping that on top of
a known matching bug would be misleading.
Note that the MAC lookup itself (iphlpapi!SendARP) only exists on Windows.
Elsewhere no MAC is resolved and MAC restrictions never match; that
limitation predates the port and is documented rather than changed.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.